From 69bcbb269d3d40d173cda8e0ccca5a614ab6a428 Mon Sep 17 00:00:00 2001 From: Dirk Van Haerenborgh Date: Thu, 13 Dec 2018 06:41:05 +0100 Subject: do not drop message and thread --- src/message.rs | 12 +++++++----- src/thread.rs | 12 +++++++----- 2 files changed, 14 insertions(+), 10 deletions(-) (limited to 'src') diff --git a/src/message.rs b/src/message.rs index 52ff63c..b4bb581 100644 --- a/src/message.rs +++ b/src/message.rs @@ -20,11 +20,13 @@ pub(crate) struct MessagePtr { pub ptr: *mut ffi::notmuch_message_t, } -impl Drop for MessagePtr { - fn drop(&mut self) { - unsafe { ffi::notmuch_message_destroy(self.ptr) }; - } -} +// TODO: The iterator doesn't actually own these, so dropping these will +// generate a segfault when a new iterator is constructed. +// impl Drop for MessagePtr { +// fn drop(&mut self) { +// unsafe { ffi::notmuch_message_destroy(self.ptr) }; +// } +// } #[derive(Debug)] pub struct Message<'o, O> diff --git a/src/thread.rs b/src/thread.rs index 1fb6814..3b58a3e 100644 --- a/src/thread.rs +++ b/src/thread.rs @@ -15,11 +15,13 @@ pub(crate) struct ThreadPtr { pub ptr: *mut ffi::notmuch_thread_t, } -impl Drop for ThreadPtr { - fn drop(&mut self) { - unsafe { ffi::notmuch_thread_destroy(self.ptr) }; - } -} +// TODO: The iterator doesn't actually own these, so dropping these will +// generate a segfault when a new iterator is constructed. +// impl Drop for ThreadPtr { +// fn drop(&mut self) { +// unsafe { ffi::notmuch_thread_destroy(self.ptr) }; +// } +// } #[derive(Debug)] pub struct Thread<'o, O> -- cgit v1.2.1