From 1d331f0707eaa4a056aa6261410fb1edb63097b7 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Gustav=20S=C3=B6rn=C3=A4s?= <gustav@sornas.net>
Date: Tue, 30 Mar 2021 16:15:53 +0200
Subject: report tcp errors all the way

---
 mumd/src/client.rs | 25 +++++++++++++------------
 1 file changed, 13 insertions(+), 12 deletions(-)

(limited to 'mumd/src/client.rs')

diff --git a/mumd/src/client.rs b/mumd/src/client.rs
index 7c1b0b7..c1a0152 100644
--- a/mumd/src/client.rs
+++ b/mumd/src/client.rs
@@ -1,11 +1,13 @@
 use crate::command;
+use crate::error::ClientError;
 use crate::network::{tcp, udp, ConnectionInfo};
 use crate::state::State;
 
+use futures_util::{select, FutureExt};
 use mumble_protocol::{Serverbound, control::ControlPacket, crypt::ClientCryptState};
 use mumlib::command::{Command, CommandResponse};
 use std::sync::Arc;
-use tokio::{join, sync::{Mutex, mpsc, oneshot, watch}};
+use tokio::sync::{Mutex, mpsc, oneshot, watch};
 
 pub async fn handle(
     state: State,
@@ -13,7 +15,7 @@ pub async fn handle(
         Command,
         oneshot::Sender<mumlib::error::Result<Option<CommandResponse>>>,
     )>,
-) {
+) -> Result<(), ClientError> {
     let (connection_info_sender, connection_info_receiver) =
         watch::channel::<Option<ConnectionInfo>>(None);
     let (crypt_state_sender, crypt_state_receiver) =
@@ -27,29 +29,28 @@ pub async fn handle(
 
     let state = Arc::new(Mutex::new(state));
 
-    //TODO report error here
-    let (_, _, _, _) = join!(
-        tcp::handle(
+    select! {
+        r = tcp::handle(
             Arc::clone(&state),
             connection_info_receiver.clone(),
             crypt_state_sender,
             packet_sender.clone(),
             packet_receiver,
             response_receiver,
-        ),
-        udp::handle(
+        ).fuse() => r.map_err(|e| ClientError::TcpError(e)),
+        _ = udp::handle(
             Arc::clone(&state),
             connection_info_receiver.clone(),
             crypt_state_receiver,
-        ),
-        command::handle(
+        ).fuse() => Ok(()),
+        _ = command::handle(
             state,
             command_receiver,
             response_sender,
             ping_request_sender,
             packet_sender,
             connection_info_sender,
-        ),
-        udp::handle_pings(ping_request_receiver),
-    );
+        ).fuse() => Ok(()),
+        _ = udp::handle_pings(ping_request_receiver).fuse() => Ok(()),
+    }
 }
-- 
cgit v1.2.1