From 85c1f17d451cf30800ea2f027bcbd15074451a78 Mon Sep 17 00:00:00 2001 From: Eskil Queseth Date: Sun, 13 Jun 2021 19:15:22 +0200 Subject: add elided-liftimes-in-paths lint --- mumd/src/main.rs | 2 ++ 1 file changed, 2 insertions(+) (limited to 'mumd/src/main.rs') diff --git a/mumd/src/main.rs b/mumd/src/main.rs index bc72779..825251e 100644 --- a/mumd/src/main.rs +++ b/mumd/src/main.rs @@ -1,3 +1,5 @@ +#![warn(elided_lifetimes_in_paths)] + mod audio; mod client; mod command; -- cgit v1.2.1 From 4c0abc2c1bf008812cdec448f50305611911cb5b Mon Sep 17 00:00:00 2001 From: Eskil Queseth Date: Sun, 13 Jun 2021 19:16:56 +0200 Subject: add keyword-idents lint --- mumd/src/main.rs | 1 + 1 file changed, 1 insertion(+) (limited to 'mumd/src/main.rs') diff --git a/mumd/src/main.rs b/mumd/src/main.rs index 825251e..f5b00c3 100644 --- a/mumd/src/main.rs +++ b/mumd/src/main.rs @@ -1,4 +1,5 @@ #![warn(elided_lifetimes_in_paths)] +#![deny(keyword_idents)] mod audio; mod client; -- cgit v1.2.1 From 90f5e8ef3c7aa61ccdb087073b2c0cf6ac52f1ee Mon Sep 17 00:00:00 2001 From: Eskil Queseth Date: Sun, 13 Jun 2021 19:17:45 +0200 Subject: add macro_use_extern_crate lint --- mumd/src/main.rs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'mumd/src/main.rs') diff --git a/mumd/src/main.rs b/mumd/src/main.rs index f5b00c3..e7a7945 100644 --- a/mumd/src/main.rs +++ b/mumd/src/main.rs @@ -1,5 +1,5 @@ #![warn(elided_lifetimes_in_paths)] -#![deny(keyword_idents)] +#![deny(keyword_idents, macro_use_extern_crate)] mod audio; mod client; -- cgit v1.2.1 From 1f41a6b9a439bab3f05e464d621eb3607116646e Mon Sep 17 00:00:00 2001 From: Eskil Queseth Date: Sun, 13 Jun 2021 19:19:31 +0200 Subject: add meta_variable_misuse lint --- mumd/src/main.rs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'mumd/src/main.rs') diff --git a/mumd/src/main.rs b/mumd/src/main.rs index e7a7945..4f611a4 100644 --- a/mumd/src/main.rs +++ b/mumd/src/main.rs @@ -1,4 +1,4 @@ -#![warn(elided_lifetimes_in_paths)] +#![warn(elided_lifetimes_in_paths, meta_variable_misuse)] #![deny(keyword_idents, macro_use_extern_crate)] mod audio; -- cgit v1.2.1 From f887f3a4f9953483c16cb4d47fbd3c5cd72f967b Mon Sep 17 00:00:00 2001 From: Eskil Queseth Date: Sun, 13 Jun 2021 19:19:58 +0200 Subject: add missing_abi lint --- mumd/src/main.rs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'mumd/src/main.rs') diff --git a/mumd/src/main.rs b/mumd/src/main.rs index 4f611a4..8dc58df 100644 --- a/mumd/src/main.rs +++ b/mumd/src/main.rs @@ -1,5 +1,5 @@ #![warn(elided_lifetimes_in_paths, meta_variable_misuse)] -#![deny(keyword_idents, macro_use_extern_crate)] +#![deny(keyword_idents, macro_use_extern_crate, missing_abi)] mod audio; mod client; -- cgit v1.2.1 From 555b8195e651fcca8c906177c784c5c50a49475c Mon Sep 17 00:00:00 2001 From: Eskil Queseth Date: Sun, 13 Jun 2021 20:07:47 +0200 Subject: add missing_debug_implementations lint --- mumd/src/main.rs | 1 + 1 file changed, 1 insertion(+) (limited to 'mumd/src/main.rs') diff --git a/mumd/src/main.rs b/mumd/src/main.rs index 8dc58df..d592cec 100644 --- a/mumd/src/main.rs +++ b/mumd/src/main.rs @@ -1,4 +1,5 @@ #![warn(elided_lifetimes_in_paths, meta_variable_misuse)] +#![warn(missing_debug_implementations)] //doesn't seem to work #![deny(keyword_idents, macro_use_extern_crate, missing_abi)] mod audio; -- cgit v1.2.1 From 78e1e35da23466126ce3411793f8985ab333140c Mon Sep 17 00:00:00 2001 From: Eskil Queseth Date: Sun, 13 Jun 2021 20:08:47 +0200 Subject: move lints to separate lines --- mumd/src/main.rs | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) (limited to 'mumd/src/main.rs') diff --git a/mumd/src/main.rs b/mumd/src/main.rs index d592cec..514de7b 100644 --- a/mumd/src/main.rs +++ b/mumd/src/main.rs @@ -1,6 +1,9 @@ -#![warn(elided_lifetimes_in_paths, meta_variable_misuse)] +#![warn(elided_lifetimes_in_paths)] +#![warn(meta_variable_misuse)] #![warn(missing_debug_implementations)] //doesn't seem to work #![deny(keyword_idents, macro_use_extern_crate, missing_abi)] +#![deny(macro_use_extern_crate, missing_abi)] +#![deny(missing_abi)] mod audio; mod client; -- cgit v1.2.1 From 9f8f46a9f91840763e10fe1b603663e346970b79 Mon Sep 17 00:00:00 2001 From: Eskil Queseth Date: Sun, 13 Jun 2021 20:10:15 +0200 Subject: oops --- mumd/src/main.rs | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'mumd/src/main.rs') diff --git a/mumd/src/main.rs b/mumd/src/main.rs index 514de7b..819402d 100644 --- a/mumd/src/main.rs +++ b/mumd/src/main.rs @@ -1,8 +1,8 @@ #![warn(elided_lifetimes_in_paths)] #![warn(meta_variable_misuse)] #![warn(missing_debug_implementations)] //doesn't seem to work -#![deny(keyword_idents, macro_use_extern_crate, missing_abi)] -#![deny(macro_use_extern_crate, missing_abi)] +#![deny(keyword_idents)] +#![deny(macro_use_extern_crate)] #![deny(missing_abi)] mod audio; -- cgit v1.2.1 From 9bc2bdc5dca1399fa75d20a18f1a2dfb8ab4e325 Mon Sep 17 00:00:00 2001 From: Eskil Queseth Date: Sun, 13 Jun 2021 20:14:59 +0200 Subject: add single_use_lifetimes lint --- mumd/src/main.rs | 1 + 1 file changed, 1 insertion(+) (limited to 'mumd/src/main.rs') diff --git a/mumd/src/main.rs b/mumd/src/main.rs index 819402d..29ea77f 100644 --- a/mumd/src/main.rs +++ b/mumd/src/main.rs @@ -1,6 +1,7 @@ #![warn(elided_lifetimes_in_paths)] #![warn(meta_variable_misuse)] #![warn(missing_debug_implementations)] //doesn't seem to work +#![warn(single_use_lifetimes)] #![deny(keyword_idents)] #![deny(macro_use_extern_crate)] #![deny(missing_abi)] -- cgit v1.2.1 From 465f21da46a7194e25894043ca2cca9ba958e11c Mon Sep 17 00:00:00 2001 From: Eskil Queseth Date: Sun, 13 Jun 2021 20:48:54 +0200 Subject: add unreachable_pub lint and fix debug impl --- mumd/src/main.rs | 17 +++++++++-------- 1 file changed, 9 insertions(+), 8 deletions(-) (limited to 'mumd/src/main.rs') diff --git a/mumd/src/main.rs b/mumd/src/main.rs index 29ea77f..6b863c1 100644 --- a/mumd/src/main.rs +++ b/mumd/src/main.rs @@ -1,18 +1,19 @@ #![warn(elided_lifetimes_in_paths)] #![warn(meta_variable_misuse)] -#![warn(missing_debug_implementations)] //doesn't seem to work +#![warn(missing_debug_implementations)] #![warn(single_use_lifetimes)] +#![warn(unreachable_pub)] #![deny(keyword_idents)] #![deny(macro_use_extern_crate)] #![deny(missing_abi)] -mod audio; -mod client; -mod command; -mod error; -mod network; -mod notifications; -mod state; +pub mod audio; +pub mod client; +pub mod command; +pub mod error; +pub mod network; +pub mod notifications; +pub mod state; use crate::state::State; -- cgit v1.2.1 From 492efc8b0dd5087991b580787ad75f0d3b57e7e7 Mon Sep 17 00:00:00 2001 From: Eskil Queseth Date: Sun, 13 Jun 2021 20:50:04 +0200 Subject: forbid unsafe --- mumd/src/main.rs | 1 + 1 file changed, 1 insertion(+) (limited to 'mumd/src/main.rs') diff --git a/mumd/src/main.rs b/mumd/src/main.rs index 6b863c1..0db6d35 100644 --- a/mumd/src/main.rs +++ b/mumd/src/main.rs @@ -6,6 +6,7 @@ #![deny(keyword_idents)] #![deny(macro_use_extern_crate)] #![deny(missing_abi)] +#![forbid(unsafe_code)] pub mod audio; pub mod client; -- cgit v1.2.1 From e21cbbb8bb35644461aad351458bfbfd3d047954 Mon Sep 17 00:00:00 2001 From: Eskil Queseth Date: Sun, 13 Jun 2021 20:56:18 +0200 Subject: add unused_crate_dependencies lint --- mumd/src/main.rs | 1 + 1 file changed, 1 insertion(+) (limited to 'mumd/src/main.rs') diff --git a/mumd/src/main.rs b/mumd/src/main.rs index 0db6d35..6dc0cf0 100644 --- a/mumd/src/main.rs +++ b/mumd/src/main.rs @@ -3,6 +3,7 @@ #![warn(missing_debug_implementations)] #![warn(single_use_lifetimes)] #![warn(unreachable_pub)] +#![warn(unused_crate_dependencies)] #![deny(keyword_idents)] #![deny(macro_use_extern_crate)] #![deny(missing_abi)] -- cgit v1.2.1 From 78d36cd1dc4b9f66baf5a323f5ca24c0ae27d766 Mon Sep 17 00:00:00 2001 From: Eskil Queseth Date: Sun, 13 Jun 2021 20:57:19 +0200 Subject: add unused_import_braces lint --- mumd/src/main.rs | 1 + 1 file changed, 1 insertion(+) (limited to 'mumd/src/main.rs') diff --git a/mumd/src/main.rs b/mumd/src/main.rs index 6dc0cf0..dc10146 100644 --- a/mumd/src/main.rs +++ b/mumd/src/main.rs @@ -4,6 +4,7 @@ #![warn(single_use_lifetimes)] #![warn(unreachable_pub)] #![warn(unused_crate_dependencies)] +#![warn(unused_import_braces)] #![deny(keyword_idents)] #![deny(macro_use_extern_crate)] #![deny(missing_abi)] -- cgit v1.2.1 From e799939afee27c47f9d78d987f50d9846b58ea8c Mon Sep 17 00:00:00 2001 From: Eskil Queseth Date: Sun, 13 Jun 2021 20:57:51 +0200 Subject: add unused_lifetimes lint --- mumd/src/main.rs | 1 + 1 file changed, 1 insertion(+) (limited to 'mumd/src/main.rs') diff --git a/mumd/src/main.rs b/mumd/src/main.rs index dc10146..536e382 100644 --- a/mumd/src/main.rs +++ b/mumd/src/main.rs @@ -5,6 +5,7 @@ #![warn(unreachable_pub)] #![warn(unused_crate_dependencies)] #![warn(unused_import_braces)] +#![warn(unused_lifetimes)] #![deny(keyword_idents)] #![deny(macro_use_extern_crate)] #![deny(missing_abi)] -- cgit v1.2.1 From 817a949cfc3b2a8687d7621eae5fdb49667adac2 Mon Sep 17 00:00:00 2001 From: Eskil Queseth Date: Sun, 13 Jun 2021 20:58:59 +0200 Subject: add unused_qualifications lint --- mumd/src/main.rs | 1 + 1 file changed, 1 insertion(+) (limited to 'mumd/src/main.rs') diff --git a/mumd/src/main.rs b/mumd/src/main.rs index 536e382..a53e1a0 100644 --- a/mumd/src/main.rs +++ b/mumd/src/main.rs @@ -6,6 +6,7 @@ #![warn(unused_crate_dependencies)] #![warn(unused_import_braces)] #![warn(unused_lifetimes)] +#![warn(unused_qualifications)] #![deny(keyword_idents)] #![deny(macro_use_extern_crate)] #![deny(missing_abi)] -- cgit v1.2.1 From a331f7867bcf065305c1e5009dc9ee9dd7a17845 Mon Sep 17 00:00:00 2001 From: Eskil Queseth Date: Sun, 13 Jun 2021 21:03:59 +0200 Subject: add future_incompatible lint --- mumd/src/main.rs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'mumd/src/main.rs') diff --git a/mumd/src/main.rs b/mumd/src/main.rs index a53e1a0..e6a3321 100644 --- a/mumd/src/main.rs +++ b/mumd/src/main.rs @@ -7,9 +7,9 @@ #![warn(unused_import_braces)] #![warn(unused_lifetimes)] #![warn(unused_qualifications)] -#![deny(keyword_idents)] #![deny(macro_use_extern_crate)] #![deny(missing_abi)] +#![deny(future_incompatible)] #![forbid(unsafe_code)] pub mod audio; -- cgit v1.2.1 From 96ac62de9f93bbd1530456369ecdb57b177564cb Mon Sep 17 00:00:00 2001 From: Eskil Queseth Date: Sun, 13 Jun 2021 21:21:28 +0200 Subject: add non_ascii_idents lint --- mumd/src/main.rs | 1 + 1 file changed, 1 insertion(+) (limited to 'mumd/src/main.rs') diff --git a/mumd/src/main.rs b/mumd/src/main.rs index e6a3321..8d278c0 100644 --- a/mumd/src/main.rs +++ b/mumd/src/main.rs @@ -11,6 +11,7 @@ #![deny(missing_abi)] #![deny(future_incompatible)] #![forbid(unsafe_code)] +#![forbid(non_ascii_idents)] pub mod audio; pub mod client; -- cgit v1.2.1 From f24f23faa240053b7ac8f65b69ff8d1ae0ad3ea1 Mon Sep 17 00:00:00 2001 From: Eskil Queseth Date: Mon, 14 Jun 2021 13:44:08 +0200 Subject: clippy --- mumd/src/main.rs | 13 ++++--------- 1 file changed, 4 insertions(+), 9 deletions(-) (limited to 'mumd/src/main.rs') diff --git a/mumd/src/main.rs b/mumd/src/main.rs index 8d278c0..6a70586 100644 --- a/mumd/src/main.rs +++ b/mumd/src/main.rs @@ -37,9 +37,7 @@ use tokio_util::codec::{FramedRead, FramedWrite, LengthDelimitedCodec}; #[tokio::main] async fn main() { - if std::env::args() - .find(|s| s.as_str() == "--version") - .is_some() + if std::env::args().any(|s| s.as_str() == "--version") { println!("mumd {}", env!("VERSION")); return; @@ -94,12 +92,9 @@ async fn main() { _ = receive_commands(command_sender).fuse() => Ok(()), }; - match run { - Err(e) => { - error!("mumd: {}", e); - std::process::exit(1); - } - _ => {} + if let Err(e) = run { + error!("mumd: {}", e); + std::process::exit(1); } } -- cgit v1.2.1 From 4b263196d3a41c99f7dc1acf659a9f9083163d5e Mon Sep 17 00:00:00 2001 From: Eskil Queseth Date: Sat, 19 Jun 2021 17:51:04 +0200 Subject: feedback --- mumd/src/main.rs | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) (limited to 'mumd/src/main.rs') diff --git a/mumd/src/main.rs b/mumd/src/main.rs index 6a70586..479c568 100644 --- a/mumd/src/main.rs +++ b/mumd/src/main.rs @@ -37,8 +37,7 @@ use tokio_util::codec::{FramedRead, FramedWrite, LengthDelimitedCodec}; #[tokio::main] async fn main() { - if std::env::args().any(|s| s.as_str() == "--version") - { + if std::env::args().any(|s| s.as_str() == "--version") { println!("mumd {}", env!("VERSION")); return; } -- cgit v1.2.1