From 47c3c5ca605fc8f2558ddb612bcc0eebcd484000 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Gustav=20S=C3=B6rn=C3=A4s?= <gustav@sornas.net>
Date: Sat, 17 Oct 2020 03:25:17 +0200
Subject: remove some TODOs handled as issues

---
 mumd/src/audio.rs       | 7 ++-----
 mumd/src/network/tcp.rs | 1 -
 2 files changed, 2 insertions(+), 6 deletions(-)

(limited to 'mumd')

diff --git a/mumd/src/audio.rs b/mumd/src/audio.rs
index a63e0cc..828942b 100644
--- a/mumd/src/audio.rs
+++ b/mumd/src/audio.rs
@@ -20,7 +20,6 @@ struct ClientStream {
     opus_decoder: opus::Decoder,
 }
 
-//TODO remove pub where possible
 pub struct Audio {
     pub output_config: StreamConfig,
     pub output_stream: Stream,
@@ -28,13 +27,12 @@ pub struct Audio {
     pub input_config: StreamConfig,
     pub input_stream: Stream,
     pub input_buffer: Arc<Mutex<VecDeque<f32>>>,
-    input_channel_receiver: Option<Receiver<VoicePacketPayload>>, //TODO unbounded? mbe ring buffer and drop the first packet
+    input_channel_receiver: Option<Receiver<VoicePacketPayload>>,
     input_volume_sender: watch::Sender<f32>,
 
-    client_streams: Arc<Mutex<HashMap<u32, ClientStream>>>, //TODO move to user state
+    client_streams: Arc<Mutex<HashMap<u32, ClientStream>>>,
 }
 
-//TODO split into input/output
 impl Audio {
     pub fn new() -> Self {
         let host = cpal::default_host();
@@ -324,7 +322,6 @@ fn input_callback<T: Sample>(
             opus_buf.truncate(result);
             let bytes = Bytes::copy_from_slice(&opus_buf);
             match input_sender.try_send(VoicePacketPayload::Opus(bytes, false)) {
-                //TODO handle full buffer / disconnect
                 Ok(_) => {}
                 Err(_e) => {
                     //warn!("Error sending audio packet: {:?}", e);
diff --git a/mumd/src/network/tcp.rs b/mumd/src/network/tcp.rs
index ea4ef86..88d2b59 100644
--- a/mumd/src/network/tcp.rs
+++ b/mumd/src/network/tcp.rs
@@ -233,7 +233,6 @@ async fn listen(
                     break;
                 }
                 Some(Some(packet)) => {
-                    //TODO handle types separately
                     match packet.unwrap() {
                         ControlPacket::TextMessage(msg) => {
                             info!(
-- 
cgit v1.2.1