aboutsummaryrefslogtreecommitdiffstats
path: root/src/tests/filst/sc-bad-write.c
diff options
context:
space:
mode:
authorklaar36 <klas.arvidsson@liu.se>2016-05-16 19:53:47 +0200
committerklaar36 <klas.arvidsson@liu.se>2016-05-16 19:53:47 +0200
commit3e648f7f87e8f9328a527faa8bb97324e67885b4 (patch)
tree5417b3a873c6c6a844d5f15d462be499e5906cd3 /src/tests/filst/sc-bad-write.c
parentc4e42961e885612ca2b84dd0246d09b86aad2b97 (diff)
parent3757af98040e80af075e10417179d1a82199d7cf (diff)
downloadpintos-rs-3e648f7f87e8f9328a527faa8bb97324e67885b4.tar.gz
Merge branch 'exec-missing-bugfix' into 'master'
Fix for possible bug in exec-missing. The test userprog/exec-missing verifies that exec() returns -1 when starting a process for which the binary is not found. Since the failure of load() is discovered after a new process has been created, the output 'no-such-file: exit(-1)' will be visible in the output. The problem is that we do not know when this happens with respect to the thread calling exec(). Due to how the tests are designed, the time when 'no-such-file' terminates is important. Some of the cases were listed as acceptable outputs, but I found some acceptable outputs missing from there, namely if 'no-such-file' for some reason takes quite some time terminating, or even terminates after the 'exec-missing' process exits. As there is no synchronization between these processes (nor can it be), we do not know which one terminates first. Effectively, I added the following possible outputs to the test, as I find them reasonable outcomes of a correct implementation (in very unfortunate circumstances, or when printing a lot in process_cleanup): ``` (exec-missing) begin load: no-such-file: open failed (exec-missing) exec("no-such-file"): -1 (exec-missing) end no-such-file: exit(-1) exec-missing: exit(0) ``` ``` (exec-missing) begin load: no-such-file: open failed (exec-missing) exec("no-such-file"): -1 (exec-missing) end exec-missing: exit(0) no-such-file: exit(-1) ``` Signed-off-by: Filip Strömbäck <filip.stromback@liu.se> See merge request !4
Diffstat (limited to 'src/tests/filst/sc-bad-write.c')
0 files changed, 0 insertions, 0 deletions